PostgreSQL with TypeORM #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeAshing
requested changes
Sep 16, 2023
| @@ -0,0 +1,8 @@ | |||
| MONGODB_URI= | |||
There was a problem hiding this comment.
It would be great if you can add the env file gitignore and change it to sample.env
| @@ -0,0 +1,25 @@ | |||
| // module.exports = { | |||
| // rules: { | ||
| // '@typescript-eslint/interface-name-prefix': 'off', | ||
| // '@typescript-eslint/explicit-function-return-type': 'off', | ||
| // '@typescript-eslint/explicit-module-boundary-types': 'off', |
There was a problem hiding this comment.
Can you please add the prettier rule here like single route to true etc
| { | ||
| "singleQuote": true, | ||
| "trailingComma": "all" | ||
| } No newline at end of file |
There was a problem hiding this comment.
can we add sem to false and tabWidth to 2
| @@ -0,0 +1,96 @@ | |||
| # NestJS Boilerplate | |||
|
|
|||
There was a problem hiding this comment.
Can you add some more details here to describe the project's core features.
| } | ||
|
|
||
| @Post('loginEmployer') | ||
| @HttpCode(HttpStatus.OK) |
| } | ||
|
|
||
| @Post('verify-jwt') | ||
| @HttpCode(HttpStatus.OK) |
| } | ||
| } | ||
|
|
||
| // This route is protected by the JwtGuard |
| useFactory: () => ({ | ||
| secret: process.env.JWT_SECRET, | ||
| signOptions: { | ||
| expiresIn: '3d', |
There was a problem hiding this comment.
can we add expires in to env file
| EmployerModule, | ||
| JwtModule.registerAsync({ | ||
| useFactory: () => ({ | ||
| secret: process.env.JWT_SECRET, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
This boilerplate is equipped with a simple CRUD for two entities User(Employee) and Employer that shares a common auth module. The PostgreSQL database is used with TypeORM for interacting with database. JWT auth with access and refresh token strategy is setup for protected routing.
Issue Number: N/A
What is the new behavior?
PostgreSQL with TypeORM
Does this PR introduce a breaking change?
Other information
All other info is mentioned in readme.md file